Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #2834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issues #2834

wants to merge 1 commit into from

Conversation

miles-six
Copy link

I have been studying this repository for a long time, and whenever I come across a typo, I fix it.

I discovered 10 typos in a total of 9 files. Then I merged them together.

The code quality is exceptionally high, so sincerely hope my PR can help make this repository more standardized.

Copy link

vercel bot commented Mar 6, 2024

@miles-six is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@miles-six
Copy link
Author

@acheroncrypto hope this pr is helpful for you

@@ -114,7 +114,7 @@ mod tests {
#[test]
#[should_panic]
fn test_cluster_bad_parse() {
let bad_url = "httq://my_custom_url.test.net";
let bad_url = "http://my_custom_url.test.net";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is deliberately a bad_url and designed to make the program panic. See test_cluster_bad_parse()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a 🤖

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol the bot author needs to make it write better PR titles - 'fix issues' 🤦🏼‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants