Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts: Change type of Provider.publicKey to PublicKey | null #2838

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kAsky53
Copy link
Contributor

@kAsky53 kAsky53 commented Mar 12, 2024

Hi @acheroncrypto, may I trouble you reviewing this PR?
Discussion goes here.

Copy link

vercel bot commented Mar 12, 2024

@kAsky53 is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@kAsky53 kAsky53 changed the title ts: change type of Provider.publicKey to PublicKey | null ts: Change type of Provider.publicKey to PublicKey | null Mar 12, 2024
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not great that these types don't match but unfortunately, this change would cause just as much incompatibility/breakage as it's trying to fix.

@kAsky53
Copy link
Contributor Author

kAsky53 commented Mar 12, 2024

It's not great that these types don't match but unfortunately, this change would cause just as much incompatibility/breakage as it's trying to fix.

Moved change log to Breaking section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants