lang: allow cfg_attr for the ix data structs #2963
Open
+58
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skrrb is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
|
@acheroncrypto do I close my PR about it? |
|
#2339 is about The reason why this PR is not merged yet is because we're trying to support invalid Rust code by using conditional derives with functions. We then have to remove this attribute from the function (because it wouldn't compile) by mutating the user's program module. Although this mutation seems fine, I'm not a fan of the nature of this code. It would be great if we could find a better way to achieve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to conditionally include attributes in the autogenerated instruction data structures
related to #2339