[cli] idl_write to wait for buffer being finished #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ochaloup is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On deploying IDL I struggle with trouble around failing to push the data to the buffer which ends with unfinished upload and failure to post the IDL on-chain.
The issue is that for me the
client.send_and_confirm_transaction_with_spinnermay fail on not being confirmed (with some blockhash not found or similar) while it still landed on the chain. With that, any follow-up retry always fails.My fix to get the IDL uploaded eventually is provided here as draft-PR and I would like to check if that makes sense to somebody else or if there is a different way to manage this.