Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change]: fix(client): Update signer method to accept a slice of signers #3116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wiseaidev
Copy link

I have refactored the signer method to accept a slice of signers for multiple signers in a single call. This change simplifies the API by reducing redundancy.

Now we can do:

.signers(&[payer, bid, ask])
.send()

Instead of:

.signer(&payer)
.signer(&bid)
.signer(&ask)
.send()

Copy link

vercel bot commented Jul 25, 2024

@wiseaidev is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's usually better to keep the old method and add a new one instead in cases like this. However, we can do an exception here to keep the API similar to the TS SDK (as it only has signers method).

client/src/blocking.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants