-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto generate the change log and releases in CI #249
Conversation
.github/workflows/dotnet-core.yml
Outdated
with: | ||
useConfigFile: true | ||
additionalArguments: '/updateprojectfiles' | ||
|
||
- name: Display updated csproj File | ||
run: cat Freshli/Freshli.csproj | ||
|
||
# Required by GitReleaseManager. Hopefully not for long. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if you could put all this into a separate Github Action job (like eclint, etc.) that would only run on main
or on a release branch so we're not building the dotnet-core.yml
file to be huge and can run this in parallel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha. I was just updating my initial PR comment with the same thought. The only issue is I would need to duplicate the GitVersion steps, which is not horrible would be nice to avoid. Do you know of a why to reuse steps in different workflow files?
I also just realized I didn't update the ReadMe. I'll do that soon the request another review. |
Code Climate has analyzed commit 0d0043d and detected 0 issues on this pull request. View more on Code Climate. |
@dfar-io I've moved the release notes logic to it's own file and it seems to work fine. Let me know what you think. We can always change the CI later if something is not working the way we like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes #241.
Currently the change log and GitHub release are updated every commit. Not sure if this should be changed to only for
main
branch merges. I also thought about putting the auto-generation of the change log and release in a separate workflow file but then would have to duplicate all the GitVersion steps. If anyone knows of a way to reuse steps in different GitHub Action workflow files let me know.You can view the Changelog in the branch and the current v0.3.0 GitHub draft release can be found here.
Finally there is an issue where the GitHub release does not format the goals with the auto-generated section. This will hopefully be fixed in v0.12.0 of GitReleaseManager when we can use templates to format the output.