FindModules: skip blib #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running this metric with Test::Kwalitee the blib/ dir usually exists with copies of the modules that will be installed. Those copies must be ignored.
|
what's wrong with looking in blib? that's where built files are going to be, after running |
|
I think that I did this patch because when CPANTS analyses the distribution content a |
|
@dolmen: yes that makes sense. We could also use the MANIFEST file (if it exists, e.g. the analyzer isn't being run in a bare repo that uses something like Dist::Zilla) for a guide as to what files we can look at, and which to ignore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kwalitee::FindModules: Do not look inblib/.PS: I am in the CPANTS Github org, but I don't have a commit bit on this repo. Is it intended?