Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid deadlock when deleting decisions if PAPI is half configured #3283

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

blotus
Copy link
Member

@blotus blotus commented Oct 11, 2024

No description provided.

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Oct 11, 2024

/kind fix
/area local-api

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.22%. Comparing base (8ff58ee) to head (cc89b8e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/apiserver.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3283      +/-   ##
==========================================
+ Coverage   39.21%   39.22%   +0.01%     
==========================================
  Files         480      480              
  Lines       62063    62063              
==========================================
+ Hits        24335    24342       +7     
+ Misses      35084    35079       -5     
+ Partials     2644     2642       -2     
Flag Coverage Δ
bats 31.40% <50.00%> (+<0.01%) ⬆️
unit-linux 34.71% <0.00%> (ø)
unit-windows 24.66% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus merged commit b2ac65b into master Oct 16, 2024
17 checks passed
@blotus blotus deleted the fix-papi-deadlock branch October 16, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants