Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context propagation: OneShotAcquisition(); enable contextcheck linter #3285

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Oct 11, 2024

No description provided.

@mmetc mmetc added the kind/enhancement New feature or request label Oct 11, 2024
@mmetc mmetc added this to the 1.6.4 milestone Oct 11, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc requested a review from blotus October 11, 2024 14:05
@mmetc mmetc marked this pull request as draft October 11, 2024 14:05
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.22%. Comparing base (3ead746) to head (6b3c81b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/appsec/appsec.go 0.00% 1 Missing ⚠️
pkg/acquisition/modules/kafka/kafka.go 0.00% 1 Missing ⚠️
pkg/acquisition/modules/kinesis/kinesis.go 0.00% 1 Missing ⚠️
...g/acquisition/modules/kubernetesaudit/k8s_audit.go 0.00% 1 Missing ⚠️
pkg/acquisition/modules/syslog/syslog.go 0.00% 1 Missing ⚠️
pkg/acquisition/modules/wineventlog/wineventlog.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
- Coverage   58.25%   58.22%   -0.04%     
==========================================
  Files         335      335              
  Lines       37427    37421       -6     
==========================================
- Hits        21804    21789      -15     
- Misses      13726    13733       +7     
- Partials     1897     1899       +2     
Flag Coverage Δ
bats 41.34% <7.14%> (-0.10%) ⬇️
unit-linux 33.99% <78.57%> (-0.02%) ⬇️
unit-windows 29.24% <38.09%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review October 11, 2024 14:39
@mmetc mmetc force-pushed the context-propagation-a7 branch 3 times, most recently from e1bc700 to 208762a Compare October 25, 2024 15:39
@mmetc mmetc merged commit 53f9bc5 into master Oct 28, 2024
17 checks passed
@mmetc mmetc deleted the context-propagation-a7 branch October 28, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants