Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] support multiple appsec configs #3314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Nov 4, 2024

cf. #2999

  • Allow AppSec to load multip appsec config at once (rules & hooks are appended, for mutually exclusive options, last value is taken into account)

Copy link

github-actions bot commented Nov 4, 2024

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Nov 4, 2024

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Project coverage is 58.22%. Comparing base (97c1f60) to head (351a41c).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/appsec/appsec.go 0.00% 53 Missing ⚠️
pkg/acquisition/modules/appsec/appsec.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
- Coverage   58.23%   58.22%   -0.01%     
==========================================
  Files         335      337       +2     
  Lines       37397    36584     -813     
==========================================
- Hits        21777    21300     -477     
+ Misses      13724    13460     -264     
+ Partials     1896     1824      -72     
Flag Coverage Δ
bats 41.40% <0.00%> (-0.01%) ⬇️
unit-linux 34.02% <0.00%> (+0.02%) ⬆️
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant