Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit config and fix linting #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bplotnick
Copy link
Contributor

This adds pre-commit to run some menial linting tasks.

The way this works is that you just run:

pip install pre-commit  # Just do this once on your machine
pre-commit install  # Do this after cloning for each repo

And then when you commit files, it will run the pre-commit checks against the changed files.

I went ahead and ran these hooks against all of the files and fixed the issues, so there should be no false positives going forward.

@cxuu
Copy link
Contributor

cxuu commented Mar 10, 2020

Could you also update the circle config to use precommit as well, so developers would have a consistent experience everywhere?

@@ -124,3 +124,5 @@ require (
launchpad.net/gocheck v0.0.0-20140225173054-000000000087 // indirect
sigs.k8s.io/yaml v1.1.0
)

go 1.13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your machine added this line behind the scenes, because you have go 1.13 installed. However if we merge it, we hav a go.mod with go 1.13, a .circleci/config.yml with go 1.12 and a Dockerfile with go 1.11.
I recommend to remove this line from your PR to not conflict with #26, and then after #26 is merged, everything is up to date on the same version 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants