Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bufq fuzzing harness #98

Merged
merged 8 commits into from
Jan 20, 2024

Conversation

elopez
Copy link
Contributor

@elopez elopez commented Jan 5, 2024

This PR refactors the existing TLV handling code to make it a bit more reusable. It then adds a new standalone harness that fuzzes the bufq buffer handling.

@elopez elopez marked this pull request as ready for review January 5, 2024 15:11
@cmeister2
Copy link
Collaborator

I'll dig in a bit more in depth later, but my top-level comment is that you don't necessarily need to keep to the TLV format for fuzzer test cases if it doesn't make sense. Does https://github.com/google/fuzzing/blob/master/docs/split-inputs.md#fuzzed-data-provider make sense for this fuzzer?

@cmeister2 cmeister2 self-assigned this Jan 9, 2024
Copy link
Collaborator

@cmeister2 cmeister2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the vision here and in general I'm a lot happier with this PR. I'm dubious as to whether a TLV mechanism here is "correct", though.

curl_fuzzer.h Outdated Show resolved Hide resolved
mainline.sh Show resolved Hide resolved
curl_fuzzer_tlv_bufq.cc Outdated Show resolved Hide resolved
@cmeister2 cmeister2 merged commit 6b8943d into curl:master Jan 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants