Randomize tasks #548
Draft
Randomize tasks #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to address cxcsds#397 but it is only a partial implementation: a) you have to opt into this when creating the TaskRunner instance, TaskRunner(randomize_insert=True) {or you could change the .randomize_insert value of the object to True, before calling run_tasks()} b) this is not a full randomization: that is, we do not randomly select from all the available tasks, but we only randomize from the set of tasks when we can add a new set of tasks, which is only going to really be useful when a barrier is processed, allowing a new set of tasks to be added to the queue. For simple cases, when running a single task adds a new task to the queue, we do not benefit. It also may be completely unhelpful, as it depends on what JoinableQueue.get does to select the next task, which appears to be under-documented.
|
@kglotfelty - if you're bored you could see if this helps |
|
I tried this with |
|
Ta for checking. As the commit mentioned this was not a "true" randomisation but a partial one, and only when adding new tasks to the queue, and only "per grouping". The JoinableQueue documentation doesn't mention how items are selected, and if that can be influenced. We could - shooting from the cuff here - subclass this queue so we can add this logic - but that's a much larger change than we want to work on at this time. |
|
I'm going to leave this open but mark as a draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to address #397 but it's only partial (it doesn't select a random task, it's just that tasks that get added may be randomized, but this does not randomize the whole set).
It is also not turned on by default. To run you would need to change
to
to test this out.