Add adql variants for source-property queries #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougBurke
force-pushed
the
add-adql-variants
branch
18 times, most recently
from
782180f
to
5c984d8
Compare
DougBurke
force-pushed
the
add-adql-variants
branch
2 times, most recently
from
104f48a
to
a0ed6b1
Compare
|
Should the "All clients" be selected (rather than "copy to clipboard") when a SAMP client is present (and an update is needed)? |
DougBurke
force-pushed
the
add-adql-variants
branch
4 times, most recently
from
7624fcd
to
27a81ed
Compare
This has been implemented (it's a bit-more than just always select "All Clients"). |
This panel is used to provide a more-obvious place for the plot and export-to-samp actions, although the latter is not set up yet. The plot-source-properties and export-to-samp actions have been moved from the control panel to this source panel. The plot code now creates the data for plotting "on the fly" rather than when the sources are initially selected.
This adds a widget that lets the user control which SAMP client the search is sent to, *including* a copy-to-clipboard option which does not require SAMP to be running. This is only implemented for the "source properties near" search, and is only partially working. The choice of targets does not react to changes (e.g. clients being added or removed, or connecting to a hub), and the visual appearance needs work.
This adds the 'find clients' option which registers WWT/CSC2 with the SAMP hub and causes the selection list to get updated with client names. This list now also updates when clients are added or removed.
…ndow' The event that triggered the copy-to-clipboard action is now passed down so that the 'clip window' can be positioned close to the mouse press.
…ifyAll The notify SAMP call doesn't report whether the client has responded, so we can't easily determine this information. As the user has selected the particular application this should be okay from a UI perspective. Note that the response from notifyAll doesn't guarantee that a client has received the message, just that one was sent, so it's not a great indicator, and was added before the recent push to make the SAMP functionality "more obvious".
…stered This reworks the target-selection list (for SAMP messages) so that the "All clients" option is only displayed (for the registered-with-the-hub case) if there are multiple clients available for the given mtype.
This also reduces the logging from the SAMP checks.
The previous behavior was to always to pick the first element (copy to clipboard) whenever the SAMP client list changed. The idea now is that the previous selection is used if it still present, otherwise use (in decreasing order of priority) - client name (single client only) or 'all clients' - copy to clipboard Export symbols and a function from wwtsamp to define the value field of the options, rather than hard-code the string values.
Allow the source display to be toggled: that is, subset the selected set of sources. The UI for this simple faceting is confusing, and the choice of options are a) not well labelled (needs to be re-written before release) b) very limited The plot button doesn't react to the subset.
The plot button is made inactive if all sources have been removed.
The main idea is to remove the chance of a user turning off a selection and the selected source should now be removed. We could handle the addition/turning back on case, but easiest just to remove both panes: source properties and nearest sources.
…option The ability to subset the source display has been moved behind an option (turned off by default on the live server).
DougBurke
force-pushed
the
add-adql-variants
branch
from
27a81ed
to
019e2dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This has been replaced by #50 and #54 so has been closed down.
Details
Could look at expanding the queries.
TODO