Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten long function names in the assembly view. #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rcaputo
Copy link
Contributor

@rcaputo rcaputo commented Mar 19, 2020

This is an experimental attempt to prevent functions with long call
signatures from wrapping the Assembly view. It's thwarted by the
disassembly also including long call signatures in branch targets.

I briefly considered hacking the disassembler output, but the embedded
syntax highlighting makes that more difficult than I wanted to tackle.
Guess I'll just need to refactor the code I work on to pass structures
around instead. :)

func_length is half R.max_value_length because it was intended to
truncate function names twice: once for the function on every line,
and again for the branch targets. I may take another pass at shortening
the branch targets if they keep bothering me.

This is an experimental attempt to prevent functions with long call
signatures from wrapping the Assembly view.  It's thwarted by the
disassembly also including long call signatures in branch targets.

I briefly considered hacking the disassembler output, but the embedded
syntax highlighting makes that more difficult than I wanted to tackle.
Guess I'll just need to refactor the code I work on to pass structures
around instead. :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant