Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul import logic and stop using projected coordinates #47

Merged
merged 7 commits into from
Dec 25, 2023

Conversation

dabreegster
Copy link
Owner

This PR is a breaking change to the binary graph file format:

  • Instead of storing Mercator coordinates and doing transformations everywhere, just store raw WGS84 coordinates. This gets rid of dependencies on old A/B Street libraries, and solves bugs where the computed route length is wrong for large areas. Closes Remove geom dependency #5.
  • Removes the dependency on osm2streets, instead importing from OSM XML or PBF using a much lighter-weight library. Closes Build from something closer to raw OSM #21.

Note this takes a dependency on georust's current boolean ops, which're known to have panics. I haven't hit any in my few simple tests so far, but if I do when updating a large user of this tool, I'll probably cut over to georust/geo#1089 and take any performance hit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build from something closer to raw OSM Remove geom dependency
1 participant