feat(waiting): add error handling for errors while waiting #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about this? |
|
Makes sense, I like it. Going to cut another version (to fix some bugs) before merging this since it is a breaking changing with the enum case change. Thanks for the PR! |
* upstream/master: 4.0.4 release move deployment target to iOS 9 to fix compile for archive with Xcode 12 Conditionally include 'swift-nio-zlib-support' dependency to avoid warning on macOS Fix compile error on Xcode 12 Switch SPM to use Swift 5.2 improve conditions for calling readLoop() Fix error when trying to convert text message partial payload to UTF-8 In FoundationTransport deinit, remove self as a delegate to InputStream and OutputStream to prevent EXC_BAD_ACCESS Update README.md Fix deprecation warning in WSCompression Fix the deadlock issue on iOS 11
|
@daltoniam Are there any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using a custom cert pinnner calling
completion(.failed(error))will update the state with statewaitingpassing the cert error.In this case we also should call the error handler.