Add preferences #84
Add preferences #84
Conversation
| @@ -25,18 +25,18 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compile fileTree(dir: 'libs', include: ['*.jar']) | |||
| androidTestCompile('com.android.support.test.espresso:espresso-core:2.2.2', { | |||
| implementation fileTree(dir: 'libs', include: ['*.jar']) | |||
README.md
Outdated
| @@ -162,10 +162,12 @@ MaterialAboutCard card = new MaterialAboutCard.Builder() | |||
|
|
|||
| ### Add Items to a card: | |||
|
|
|||
| There are currently two types of items you can add to a card - [`MaterialAboutTitleItem`][9] and [`MaterialAboutActionItem`][10]. Other types of items are planned, for example "person" items which feature buttons to showcase a single person. Feel free to submit a PR or Issue for more item ideas. | |||
| There are currently 4 types of items you can add to a card - [`MaterialPreferenceTitleItem`][9], [`MaterialPreferenceActionItem`][10], [`MaterialPreferenceCheckboxItem`][12] and [`MaterialPreferenceSwitchItem`][13]. Other types of items are planned, for example "person" items which feature buttons to showcase a single person. Feel free to submit a PR or Issue for more item ideas. | |||
There was a problem hiding this comment.
Could we use the naming convention MaterialAboutCheckboxItem and MaterialAboutTitleItem etc. Thanks
build.gradle
Outdated
| @@ -28,6 +28,7 @@ ext { | |||
| minSdkVersion = 14 | |||
|
|
|||
| supportLibVersion = '27.1.1' | |||
| constraintLayoutLibVersion = '1.1.0' | |||
There was a problem hiding this comment.
Is the constraint layout library used at all?
| /** | ||
| * Created by François Dexemple on 04/05/2018 | ||
| */ | ||
| public interface MaterialAboutOnCheckedChangedListener { |
There was a problem hiding this comment.
Can we rename this to MaterialAboutItemOnCheckedChangedAction for consistency. Thanks
There was a problem hiding this comment.
Yes I will do it but it's not really an action (like click), it's a listener
| @@ -1,28 +1,39 @@ | |||
| package com.danielstone.materialaboutlibrary.util; | |||
|
|
|||
| import android.content.Context; | |||
| import android.icu.util.ValueIterator; | |||
| @@ -0,0 +1,85 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <android.support.constraint.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
Ahh. Could you possibly create the layout with LinearLayouts etc, just to keep dependencies down when not needed. :)
| @@ -0,0 +1,84 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <android.support.constraint.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
|
I made the corrections. The only details I did not manage to do with Linear layout is to center the switch and the checkbox. You'll see when you put a checkbox under a switch that they are not centered |
|
Thanks! I'll check it out and merge onto master branch later |
|
I forget some error in the README. See PR #86 |
#77