Skip to content

Commit

Permalink
Fix incorrectly documentet kwargs in AWS ECS (#426)
Browse files Browse the repository at this point in the history
when kwargs is typed as `kwargs: dict`, this is interpreted as Dict[str, dict]. See https://peps.python.org/pep-0484/#arbitrary-argument-lists-and-default-argument-values
  • Loading branch information
dymbe authored May 13, 2024
1 parent 35e4d1d commit e9abdfb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions dask_cloudprovider/aws/ecs.py
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ class Scheduler(Task):
Any extra command line arguments to pass to dask-scheduler, e.g. ``["--tls-cert", "/path/to/cert.pem"]``
Defaults to `None`, no extra command line arguments.
kwargs: Dict()
kwargs:
Other kwargs to be passed to :class:`Task`.
See :class:`Task` for parameter info.
Expand Down Expand Up @@ -413,7 +413,7 @@ class Worker(Task):
scheduler: str
The address of the scheduler
kwargs: Dict()
kwargs:
Other kwargs to be passed to :class:`Task`.
"""

Expand Down Expand Up @@ -682,7 +682,7 @@ class ECSCluster(SpecCluster, ConfigMixin):
mounted in worker tasks. This setting controls whether volumes are also mounted in the scheduler task.
Default ``False``.
**kwargs: dict
**kwargs:
Additional keyword arguments to pass to ``SpecCluster``.
Examples
Expand Down Expand Up @@ -1396,7 +1396,7 @@ class FargateCluster(ECSCluster):
Parameters
----------
kwargs: dict
kwargs:
Keyword arguments to be passed to :class:`ECSCluster`.
Examples
Expand Down

0 comments on commit e9abdfb

Please sign in to comment.