Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(front): modal project #99

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

chore(front): modal project #99

wants to merge 6 commits into from

Conversation

OlivPi
Copy link
Contributor

@OlivPi OlivPi commented Mar 6, 2023

chore(front): màj kepler theme fix

@OlivPi OlivPi changed the title chore(front): initial commit modal project chore(front): modal project Mar 6, 2023
@OlivPi OlivPi force-pushed the modal-rename-project branch 2 times, most recently from db83a4f to 344cd9e Compare March 8, 2023 14:12
@OlivPi OlivPi self-assigned this Mar 13, 2023
@OlivPi OlivPi added the enhancement New feature or request label Mar 13, 2023
@OlivPi OlivPi marked this pull request as ready for review March 13, 2023 16:16
lutangar
lutangar requested changes Mar 14, 2023
View reviewed changes
apps/frontend/src/components/modal/ModalProject.tsx Outdated
z-index: ${({ theme }) => theme.modalContentZ};
`;

const ModalContent = styled.div`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use StyledModalContent instead of a simple div.

apps/frontend/src/components/modal/ModalProject.tsx Outdated
onClose: () => void;
}

const StyledModalContainer = styled(Modal)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should find out how to leverage Kepler ModalContainer instead.

@OlivPi OlivPi mentioned this pull request Mar 15, 2023
Open
31 tasks
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
4.9% 4.9% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
12.4% 12.4% Duplication

@OlivPi
Copy link
Contributor Author

OlivPi commented Apr 27, 2023

This branch present different Modal template from Datatlas. You can see a description in Modals System #104

It need to connect with the ModalContainerFactory to override the Kepler modals system.

@lutangar
Copy link
Contributor

About the status of this branch, it seems to be a work in progress rather than being ready to be merge, am I correct ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lutangar lutangar lutangar requested changes

@Pipazoul Pipazoul Awaiting requested review from Pipazoul

Assignees

@OlivPi OlivPi

Labels
enhancement New feature or request
Projects
DatAtlas project
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlivPi @lutangar