[GSOC'24 Amharic chapter] Implement Date time parser for Ethiopian Calendar #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meti-Adane
commented
Aug 21, 2024
Meti-Adane
commented
- Implements Ethiopian date to Gregorian calendar conversion for Amharic extractions.
- Implements Geez number to Arabic numeral conversion for dates written in geez number.
- Address concern mentioned in Issue 761
TallTed
suggested changes
Aug 22, 2024
core/src/main/scala/org/dbpedia/extraction/util/GeezNumberUtils.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/dbpedia/extraction/util/GeezNumberUtils.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/org/dbpedia/extraction/dataparser/DateTimeParserTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/org/dbpedia/extraction/dataparser/DateTimeParserTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/org/dbpedia/extraction/dataparser/DateTimeParserTest.scala
Outdated
Show resolved
Hide resolved
| @@ -6,6 +6,8 @@ object DateTimeParserConfig | |||
| val monthsMap = Map( | |||
| // For "ar" configuration, right-to-left rendering may seem like a bug, but it's not. | |||
| // Don't change this unless you know how it is done. | |||
| "am" -> Map("january"->1,"february"->2,"march"->3,"april"->4,"may"->5,"june"->6,"july"->7,"august"->8,"september"->9,"october"->10,"november"->11,"december"->12, | |||
There was a problem hiding this comment.
Suggested change
| "am" -> Map("january"->1,"february"->2,"march"->3,"april"->4,"may"->5,"june"->6,"july"->7,"august"->8,"september"->9,"october"->10,"november"->11,"december"->12, | |
| "am" -> Map("January"->1,"February"->2,"March"->3,"April"->4,"May"->5,"June"->6,"July"->7,"August"->8,"September"->9,"October"->10,"November"->11,"December"->12, |
There was a problem hiding this comment.
Not sure if doing uppercase is correct since all other language mappings are lowercase,
IIRC we lowercase our input before processing and this could change could skip the matching
core/src/main/scala/org/dbpedia/extraction/dataparser/EthiopianDateParser.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/dbpedia/extraction/dataparser/EthiopianDateParser.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/org/dbpedia/extraction/dataparser/DateTimeParserTest.scala
Outdated
Show resolved
Hide resolved
jimkont
approved these changes
Sep 3, 2024
| @@ -6,6 +6,8 @@ object DateTimeParserConfig | |||
| val monthsMap = Map( | |||
| // For "ar" configuration, right-to-left rendering may seem like a bug, but it's not. | |||
| // Don't change this unless you know how it is done. | |||
| "am" -> Map("january"->1,"february"->2,"march"->3,"april"->4,"may"->5,"june"->6,"july"->7,"august"->8,"september"->9,"october"->10,"november"->11,"december"->12, | |||
There was a problem hiding this comment.
Not sure if doing uppercase is correct since all other language mappings are lowercase,
IIRC we lowercase our input before processing and this could change could skip the matching
core/src/test/scala/org/dbpedia/extraction/dataparser/DateTimeParserTest.scala
Outdated
Show resolved
Hide resolved
…s.scala Co-authored-by: Ted Thibodeau Jr <[email protected]>
…s.scala Co-authored-by: Ted Thibodeau Jr <[email protected]>
…ParserTest.scala Co-authored-by: Ted Thibodeau Jr <[email protected]>
…ParserTest.scala Co-authored-by: Ted Thibodeau Jr <[email protected]>
…ParserTest.scala Co-authored-by: Ted Thibodeau Jr <[email protected]>
…nDateParser.scala Co-authored-by: Ted Thibodeau Jr <[email protected]>
…nDateParser.scala Co-authored-by: Ted Thibodeau Jr <[email protected]>
…ParserTest.scala Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.