Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme 025 lz #19

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

leilazaazhoa
Copy link

No description provided.

@ashabed
Copy link
Contributor

ashabed commented Aug 20, 2017

A few notes:
1- The commit message "25" doesn't tell me what was done. It'd likely get the pull request rejected on a team until a self explanatory commit message was provided.
2- New tasks should be based off of the updated develop branch. It seems like this may have been based off of the previous classwork because there are commits for creating the bootstrap subtheme, which was already done and merged into the develop branch by the time class started
3- The commit message "configuration" - same comment as number 1, it doesn't tell me what work you did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants