chore: change heroku build to create review apps for pr's to master (#…

…1489)
decentraland · Dec 22, 2023 · ba33121 · ba33121
1 parent 2d34548
commit ba33121
Showing 1 changed file with 24 additions and 6 deletions.
diff --git a/.github/workflows/heroku_build.yml b/.github/workflows/heroku_build.yml
@@ -4,6 +4,9 @@ on:
   push:
     branches:
       - master
+  pull_request:
+    branches:
+      - master
 
 jobs:
   build-push:
@@ -24,25 +27,40 @@ jobs:
       - name: installing
         run: npm ci
 
-      - name: build image
+      - name: Set Heroku App Name
+        run: |
+          if [ "${{ github.event_name }}" = "pull_request" ]; then
+            HEROKU_APP_NAME=governance-pr-${{ github.event.number }}
+          else
+            HEROKU_APP_NAME=dcl-governance
+          fi
+          echo "HEROKU_APP_NAME=$HEROKU_APP_NAME" >> $GITHUB_ENV
+
+      - name: Build image
         run: |
           docker build -t governance:${{ github.sha }} \
                        --build-arg version_number=${{ github.sha }} \
-                       --build-arg heroku_app_name=dcl-governance .
+                       --build-arg heroku_app_name=$HEROKU_APP_NAME .
 
       - name: Log in to Heroku Container Registry
         env:
           HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
         run: heroku container:login
 
       - name: Tag and Push to Heroku
-        id: push-to-heroku
         run: |
-              docker tag governance:${{ github.sha }} registry.heroku.com/dcl-governance/web
-              docker push registry.heroku.com/dcl-governance/web
+          docker tag governance:${{ github.sha }} registry.heroku.com/$HEROKU_APP_NAME/web
+          docker push registry.heroku.com/$HEROKU_APP_NAME/web
+
+      - name: Enable Heroku Dyno Metadata
+        if: github.event_name == 'pull_request'
+        run: heroku labs:enable runtime-dyno-metadata -a $HEROKU_APP_NAME
+        env:
+          HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
 
       - name: Release the Image
         id: release-image
         env:
           HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
-        run: heroku container:release web -a dcl-governance
+        run: heroku container:release web -a $HEROKU_APP_NAME
+