-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 'about' response local scene parcels #1013
Conversation
…arcels collection in 'about' reponse message
Deploying js-sdk-toolchain with Cloudflare Pages
|
Test this pull request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the goal is to set the boundaries for the landscape, I suggest using the map
field to specify the size (and compute the landscape as a function of it), recently introduced in the protocol .
See the response of the genesis-city
one (I think it's still hardcoded in EA, but it's ready to be used!) https://peer.decentraland.org/about
Uhmm in the Explorer side I'm needing the local scene occupied parcels before actually loading any scene, for local scene development, so that based on those parcels the dynamic landscape can get generated during initialization, the same that the Explorer Alpha does for worlds but wasn't able to do it for local scenes because worlds have their collection of ipfs urn scenes in the realm. Maybe in the future we can use your approach (would need a bigger refactor of all the landscape terrain generation logic in Explorer Alpha) but right now all the dynamic landscape complexity only needs a list of parcels (or urn scenes, as in the case of worlds). |
I understand. Let's go ahead and merge this temporarily to avoid blocking anything (if there's urgency), but let's not commit to keeping it in the about section permanently just because of this (at least we agreed it's completely necessary). |
Added local scenes parcels info in 'about' reponse message, so that the Explorer can use that to generate the dynamic landscape for local scene development.
Related PRS: