POC: send status notifications #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test this pull request
|
Julieta11
reviewed
Jul 27, 2023
| } | ||
|
|
||
| message Position { | ||
| optional string realm = 1; |
There was a problem hiding this comment.
I'm not sure what we do with the realm, but I think it would be a good idea to check it and consider if it'd be better to change the type from string to enum
There was a problem hiding this comment.
I’m not sure also how does the explorer handle it. Anyway, when being in a world the world name is the realm, so at first we can not list all the possible names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPC protocol to implement the Presence feature in Social Service PoC