fix: unique file naming #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test this pull request
|
|
Should we push this, or close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Change comms.proto files to have an unique name.
Why?
Currently,
comms v1,comms v2, andcomms v3are not included in thepublic\comms.proto, and that is the reason that is not throwing an error (we could remove those because they are not used right now), but when you're generating the code from the files themselves (proto/**/*.proto), thecomms.protoname is repeated x5 times, so there is a conflict there.For generating C# files, I couldn't manage to generate the files from the imported files (what is in public/*.proto).
Breaking change
Some projects need to fix the filename imports, there is no protocol breaking change