Skip to content

Commit

Permalink
feat: Use Node 18 (#511)
Browse files Browse the repository at this point in the history
* feat: Use Node 18

* fix: Changed 19 to 18

* fix: Storybook build
  • Loading branch information
LautaroPetaccio authored Feb 27, 2024
1 parent d8ab990 commit fc83d24
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 17 deletions.
20 changes: 11 additions & 9 deletions .github/workflows/master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@ on:
name: Publish NPM package
jobs:
build:
permissions:
id-token: write
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- name: Use Node.js 16.x
uses: actions/setup-node@v1
- name: Use Node.js 18.x
uses: actions/setup-node@v4.0.1
with:
node-version: 16.x
node-version: 18.x
- name: Cache node modules
id: cache-npm
uses: actions/cache@v3
Expand Down Expand Up @@ -46,10 +48,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- name: Use Node.js 16.x
uses: actions/setup-node@v1
- name: Use Node.js 18.x
uses: actions/setup-node@v4.0.1
with:
node-version: 16.x
node-version: 18.x
- name: Cache node modules
id: cache-npm
uses: actions/cache@v3
Expand Down Expand Up @@ -95,10 +97,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- name: Use Node.js 16.x
uses: actions/setup-node@v1
- name: Use Node.js 18.x
uses: actions/setup-node@v4.0.1
with:
node-version: 16.x
node-version: 18.x
- name: Cache node modules
id: cache-npm
uses: actions/cache@v3
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
on:
push:
branches-ignore:
- "master"
- "main"
- 'master'
- 'main'
pull_request:

name: PR Validation
Expand All @@ -11,10 +11,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- name: Use Node.js 16.x
uses: actions/setup-node@v1
- name: Use Node.js 18.x
uses: actions/setup-node@v4.0.1
with:
node-version: 16.x
node-version: 18.x
- name: Cache node modules
id: cache-npm
uses: actions/cache@v3
Expand Down
9 changes: 6 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
"typings": "lib/index.d.ts",
"scripts": {
"test": "jest",
"start": "start-storybook -p 6006",
"start": "node --openssl-legacy-provider ./node_modules/.bin/start-storybook -p 6006",
"build": "npm run build:lib && npm run build:dist ",
"build:lib": "rimraf lib && webpack --config webpack.config.js",
"build:storybook": "build-storybook && cp ./static/* ./storybook-static && node postbuild",
"build:lib": "rimraf lib && node --openssl-legacy-provider ./node_modules/.bin/webpack --config webpack.config.js",
"build:storybook": "node --openssl-legacy-provider ./node_modules/.bin/build-storybook && cp ./static/* ./storybook-static && node postbuild",
"build:dist": "rimraf dist && tsc -p . -d --outDir dist --declarationDir dist --sourceMap false --skipLibCheck && postcss --base src --dir dist 'src/**/*.css'",
"check:prettier": "prettier -c 'src/**/*.{js,ts,json,yml,md,tsx,html,css}'",
"check:code": "eslint . --max-warnings=0",
Expand Down Expand Up @@ -105,6 +105,9 @@
"semantic-ui-react": "^2.0.3",
"uuid": "^9.0.1"
},
"engines": {
"node": "18"
},
"peerDependencies": {
"react": "^16.8.0 || ^17.0.0",
"react-dom": "^16.8.0 || ^17.0.0"
Expand Down

0 comments on commit fc83d24

Please sign in to comment.