Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: optimize finilizeWearableLoadingSystem #2442

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

popuz
Copy link
Collaborator

@popuz popuz commented Oct 15, 2024

What does this PR change?

fix #2283

Get almost x3 boost for the System
(legend: blue 🔵 - dev, orange 🟠- this branch)
image

dev:
image

branch:
image

How to test the changes?

  1. Launch the explorer
  2. Smoke test that all things with wearables are working fine - like backpack and passport of others, some special wearables collections, wearables of other players, emotes

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@popuz popuz self-assigned this Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit f47cfc9
Logs https://github.com/decentraland/unity-explorer/actions/runs/11380263335
Download Windows https://github.com/decentraland/unity-explorer/suites/29732213989/artifacts/2067538110
Download Mac https://github.com/decentraland/unity-explorer/suites/29732213989/artifacts/2067571246
Built on 2024-10-17T08:01:38Z

@popuz popuz changed the title Chore/optimize finilize wearable loading sys Chore: optimize finilizeWearableLoadingSystem Oct 15, 2024
@popuz popuz marked this pull request as ready for review October 15, 2024 15:50
@popuz popuz requested review from m3taphysics and lorux0 and removed request for dalkia and davidejensen October 15, 2024 15:58
@popuz popuz added clean-build Used to trigger clean build on PR and removed clean-build Used to trigger clean build on PR labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize FinalizeWearableLoadingSystem / Reduce Allocations
1 participant