fix: issues with quick transition between LOD - Scene - LOD - Scene #2462
+66
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
anicalbano
reviewed
Oct 16, 2024
There was a problem hiding this comment.
🟢 Checked and working as expected! Alongside the test, the following smoke was performed:
✔️ Backpack/Emotes/Wearables
✔️ Social interaction on Chat/My Profile
✔️ Teleport with /goto and Map
16.10.2024_11.25.43_REC.mp4
Leaving a commend and awaiting for Mac test for fully approval 😄
DafGreco
approved these changes
Oct 16, 2024
anicalbano
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Added a small time before we switch from a scene/scene promise to a LOD, reducing the visual glitches and reducing the edge cases caused by quickly panning around the camera.
How to test the changes?
Go to -150,0, zoom into 1st person view, then approach the lonely house at -150,-3 until it changes from LOD to Scene. Then zoom out. It should take about 5seconds until it turns into LOD again. If you zoom in, it will turn into a scene again.
This delay should work for all scenes allowing to pan the camera around and leave a scene and come back without it changing too quickly to LODs.
Please let me know if the time set is OK or if we need more time for the change to happen.
2024-10-16.13-39-49.mp4