chore: adjust minimum camera distance for main avatar visibility #2468
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
AlejandroAlvarezMelucciDCL
approved these changes
Oct 16, 2024
| @@ -13,7 +13,7 @@ namespace DCL.AvatarRendering.AvatarShape.Systems | |||
| [UpdateInGroup(typeof(CameraGroup))] | |||
| public partial class AvatarShapeVisibilitySystem : BaseUnityLoopSystem | |||
| { | |||
| private const float AVATAR_MINIMUM_CAMERA_DISTANCE_SQR = 1; | |||
| private const float AVATAR_MINIMUM_CAMERA_DISTANCE_SQR = 3.5f * 3.5f; | |||
There was a problem hiding this comment.
I know it's a const and will be calculated once, but is there a reason not to have the final value and have it written like this?
There was a problem hiding this comment.
For me it's easier to know we mean "3.5 meters" otherwise if I put 12.25 I have to go and make the calculation to know what actual distance we are talking about.
There was a problem hiding this comment.
I see, makes perfect sense! Thanks 😋
Ludmilafantaniella
approved these changes
Oct 16, 2024
pravusjif
requested review from
fcolarich and
anicalbano
and removed request for
dalkia and
lorux0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
Right now when performance degrades a lot and therea re hiccups in the main thread, the main camera following (in first person camera) can't keep up with the main player position, thus getting outside the minimum camera distance range that hides the main avatar in first person mode.
WHAT
Adjusted minimum camera distance for hiding the avatar by testing in a specific place where the problem is always reproducible.
TEST STEPS
Put the camera in first person mode, go to
51, 72and move towards the center of the Art Week Plaza to reproduce the issue, as shown in the video:Screen.Recording.2024-10-16.at.8.47.14.PM.mp4
Do the same with the build from this PR and confirm that the problem doesn't happen anymore.