add track for launch from dcl-editor #2476
Open
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed! Check the logs to see what went wrong |
github-actions
bot
requested review from
lorux0,
Ludmilafantaniella and
mikhail-dcl
pravusjif
approved these changes
Oct 17, 2024
AlejandroAlvarezMelucciDCL
approved these changes
Oct 17, 2024
| private static string ChooseRuntime(IAppArgs appArgs) | ||
| { | ||
| if (Application.isEditor) | ||
| return "unity-editor"; |
There was a problem hiding this comment.
Shall we make all these literals const?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Extended
runtimefield of analytics context with the support of launch fromdcl-editorHow to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md