txscript: group reserved op code tests. #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
changed the title
davecgh
requested changes
Jul 29, 2018
txscript/data/script_tests.json
Outdated
| ["0", "IF 0xfd ELSE 1 ENDIF", "NONE", "OK", "Reserved opcode 0xfd allowed if not executed"], | ||
| ["0", "IF 0xfe ELSE 1 ENDIF", "NONE", "OK", "Reserved opcode 0xfe allowed if not executed"], | ||
| ["0", "IF 0xff ELSE 1 ENDIF", "NONE", "OK", "Reserved opcode 0xff allowed if not executed"], | ||
| ["RESERVED opcode tests"], |
txscript/data/script_tests.json
Outdated
| ["NOP", "BLAKE256 1", "NONE", "ERR_INVALID_STACK_OPERATION"], | ||
| ["NOP", "HASH160 1", "NONE", "ERR_INVALID_STACK_OPERATION"], | ||
| ["NOP", "HASH256 1", "NONE", "ERR_INVALID_STACK_OPERATION"], | ||
| ["0x00", "SIZE 0 EQUAL", "NONE", "OK", "Basic OP_0 execution"], |
There was a problem hiding this comment.
I believe this should be up under the Tests for test harness itself section.
txscript/data/script_tests.json
Outdated
| ["NOP", "HASH160 1", "NONE", "ERR_INVALID_STACK_OPERATION"], | ||
| ["NOP", "HASH256 1", "NONE", "ERR_INVALID_STACK_OPERATION"], | ||
| ["0x00", "SIZE 0 EQUAL", "NONE", "OK", "Basic OP_0 execution"], | ||
| ["0x00", "'00' EQUAL", "NONE", "ERR_EVAL_FALSE", "Basic OP_0 execution"], |
There was a problem hiding this comment.
Should be in the EQUAL test coverage section.
txscript/data/script_tests.json
Outdated
|
|
||
| ["NOP1","NOP10", "NONE", "ERR_EMPTY_STACK"], | ||
| ["1", "0x02 0x0100 EQUAL NOT", "NONE", "OK", "Not the same byte array..."], | ||
| ["0", "0x01 0x80 EQUAL NOT", "NONE", "OK"], |
There was a problem hiding this comment.
Should be in the EQUAL test coverage section.
txscript/data/script_tests.json
Outdated
|
|
||
| ["NOP1","NOP10", "NONE", "ERR_EMPTY_STACK"], | ||
| ["1", "0x02 0x0100 EQUAL NOT", "NONE", "OK", "Not the same byte array..."], |
There was a problem hiding this comment.
Should be in the EQUAL test coverage section.
txscript/data/script_tests.json
Outdated
| ["NOP", "0 'a'{2048} <'b'{2048}>{6} 'b'{2024}", "NONE", "ERR_SCRIPT_SIZE", "16385-byte scriptPubKey"], | ||
| ["1 IF 1 ELSE", "0xff ENDIF", "NONE", "ERR_UNBALANCED_CONDITIONAL", "Invalid because scriptSig and scriptPubKey are processed separately"], |
There was a problem hiding this comment.
Should be in the IF test coverage section
txscript/data/script_tests.json
Outdated
| ["1 0x01 NOP10", "HASH160 0x14 0xa880c3383e77efb97808a87ca378539e5f8904ef EQUAL", "DISCOURAGE_UPGRADABLE_NOPS", "ERR_DISCOURAGE_UPGRADABLE_NOPS", "Discouraged NOP10 in redeemScript"], | ||
| ["1", "NOP", "DISCOURAGE_UPGRADABLE_NOPS", "OK", "Discourage NOPx flag allows OP_NOP"], |
There was a problem hiding this comment.
Should be in the NOP test coverage section.
dnldd
force-pushed
the
reserved_tests
branch
3 times, most recently
from
93beed8
to
7545adb
Compare
this groups reserved op codes and moves some dangling tests to their respective groups.
davecgh
approved these changes
Jul 30, 2018
vctt94
pushed a commit
to vctt94/dcrd
that referenced
this pull request
Mar 29, 2019
build: tidy go modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work towards #1331