txscript: group numeric encoding tests with their opcodes. #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
numeric-minimal-tests
branch
from
63901fc
to
f9cce04
Compare
davecgh
requested changes
Aug 6, 2018
txscript/data/script_tests.json
Outdated
| @@ -785,6 +788,7 @@ | |||
| ["22 21 20", "0 PICK 20 EQUALVERIFY 2DROP DROP 1", "CLEANSTACK", "OK"], | |||
| ["22 21 20", "1 PICK 21 EQUALVERIFY 2DROP DROP 1", "CLEANSTACK", "OK"], | |||
| ["22 21 20", "2 PICK 22 EQUALVERIFY 2DROP DROP 1", "CLEANSTACK", "OK"], | |||
| ["1 0x02 0x0000", "PICK DROP", "NONE", "ERR_MINIMAL_DATA"], | |||
There was a problem hiding this comment.
Since these were split up from the section comment that described what they're doing, please add individual comments accordingly.
This also moves some dangling tests to their respective opcode groupings as well as some updates to test comments.
dnldd
force-pushed
the
numeric-minimal-tests
branch
from
f9cce04
to
4bcec8b
Compare
davecgh
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also moves some dangling tests to their respective opcode groupings.
Work towards #1331.