Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGC GeoPackage implementation - 3.4 #333

Closed

Conversation

diegomigliavacca
Copy link
Contributor

http://tracker.deegree.org/deegree-services/ticket/613

"The GeoPackage specification describes an open, standards-based, platform-independent, portable, self-describing, compact format for transferring geospatial information. It is a set of conventions for SQLite to store interoperable Features and/or Tiles on a common base" (opengis/geopackage GitHub repository).

For the feature part, the user needs to configure in Deegree:
an SQL feature store;
a WFS service;
a JDBC connection;
a Feature Layer.

For the tile part, the user needs to configure:
a WMTS service;
a Gpkg Tile Store;
a Tile Layer.

Configuration of a JDBC connection (example):

<JDBCConnection configVersion="3.0.0" xmlns="http://www.deegree.org/jdbc" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 xsi:schemaLocation="http://www.deegree.org/jdbc http://schemas.deegree.org/jdbc/3.0.0/jdbc.xsd">

 <Url>jdbc:sqlite:/home/user/World.gpkg</Url>
 <User>null</User>
 <Password>null</Password>

</JDBCConnection>

User and Password can just to be set to "null", given that GeoPackage is based on SQLite.

Configuration of a Gpkg Tile Store (example):

<GpkgTileStore xmlns="http://www.deegree.org/datasource/tile/gpkg" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.deegree.org/datasource/tile/gpkg http://schemas.deegree.org/datasource/tile/gpkg/3.2.0/geopackage.xsd" configVersion="3.2.0">

  <TileDataSet>
    <Identifier>gpkg_tiledataset</Identifier>
    <File>home/user/World.gpkg</File>
    <TileMapping table="fromosm_tiles"/>
    <!-- [0..1]: the mime type of the desired image output format.   Default is image/png -->
    <ImageFormat>image/png</ImageFormat>
  </TileDataSet>

</GpkgTileStore>

@diegomigliavacca
Copy link
Contributor Author

With the OracleJDK, the build succeeded.
With the OpenJDK there is the following error message:

WARN: The method class org.apache.commons.logging.impl.SLF4JLogFactory#release() was invoked.
WARN: Please see http://www.slf4j.org/codes.html#release for an explanation.

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

The build has been terminated

@diegomigliavacca
Copy link
Contributor Author

I tested this Geopackage implementation and it works properly. Besides, on my Pc, with the Oracle JDK, there aren't test failures during the build process using "mvn clean install -Pintegration-tests". I suggest to test it again on some other computer, maybe with OpenJDK too. Then, I think it will be possible to integrate it in Deegree.

@dstenger
Copy link
Contributor

TravisCI failed as some artifacts could not be fetched:

[ERROR] Failed to execute goal on project deegree-core-commons: Could not resolve dependencies for project org.deegree:deegree-core-commons:jar:3.4-pre16-SNAPSHOT: The following artifacts could not be resolved: jogl:jogl:jar:1.1.2, org.deegree:deegree-ogcschemas:jar:20120804: Could not find artifact jogl:jogl:jar:1.1.2 in central (http://repo.maven.apache.org/maven2) -> [Help 1]

@MrSnyder
Copy link
Contributor

Thank you for your contribution. Unfortunately, it cannot be merged automatically. It cannot be considered for inclusion, before this has been fixed. Please rebase it against the target branch.

@tfr42 tfr42 added needs rebase PR is not up to date and needs rebase and removed tests failing unit or Integration tests fail labels Nov 11, 2014
@diegomigliavacca
Copy link
Contributor Author

I did it. Now my branch is up to date.

@tfr42 tfr42 removed the needs rebase PR is not up to date and needs rebase label Jan 10, 2015
@tfr42
Copy link
Member

tfr42 commented Feb 6, 2015

Thank you for your contribution. Your pull request has been discussed by the TMC today. Please see the following remarks from the TMC members:

  • We need at least some documentation for the deegree webservices handbook
  • And since it affects the deegree console we are in favor in move to a later stable release version of 3.4

However, we found that it is not ready yet for inclusion:
The TMC would be happy if can find the time to address these shortcomings and participate.

@diegomigliavacca
Copy link
Contributor Author

I think it's a really good idea to move it to a later stable release version of 3.4.
I will test this implementation again in a later stable release and I will improve it.
I will contact you about the documentation for the webservices handbook.

@tfr42 tfr42 added the contributions welcome asking for contribution (time and money sponsor) label Mar 4, 2015
@MrSnyder MrSnyder added the stuck stuck label Apr 24, 2015
@tfr42 tfr42 removed the in progress label Oct 1, 2015
@tfr42
Copy link
Member

tfr42 commented Nov 30, 2018

Dear deegree users! If someone of you would like this PR merged and want this as an official part of deegree, then please act now. Either rebase and fix the build or post a comment. Otherwise we will close this PR soon.

@tfr42 tfr42 added the hard label Dec 14, 2018
@tfr42
Copy link
Member

tfr42 commented Dec 14, 2018

TMC consider this PR as very interesting and would like to continue. Volunteers are very welcome! Please get in contact with the TMC.

@@ -92,6 +92,7 @@ public void startup( Workspace workspace ) {
try {
for ( Driver d : ServiceLoader.load( Driver.class, workspace.getModuleClassLoader() ) ) {
registerDriver( new DriverWrapper( d ) );
registerDriver( new DriverWrapper( new org.sqlite.JDBC() ) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if instantiating the driver manually is a good idea.

@copierrj
Copy link
Member

@diegomigliavacca Thank you for updating this pull request! Unfortunately Travis CI was not able to build and test your branch.

@copierrj copierrj removed stuck stuck marked for deletion PR with that label will be closed soon needs rebase PR is not up to date and needs rebase labels Jan 11, 2019
@diegomigliavacca
Copy link
Contributor Author

Hi!! Yes, removing that registerDriver was the main task. For the rest, you only have to upgrade the Deegree version in the pom.xml files and update the dependencies in the geopackage pom files. Then, it will work.
Unfortunately, right now I don't have much free time to test this feature against different Geopackage files, raster and vector. Eventually, if someone is interested in this feature, as soon as possible I will test it on my PC and I will make the code available through GitHub.

@tfr42 tfr42 added this to the Backlog milestone Jun 14, 2019
@tfr42 tfr42 added stuck stuck and removed hard CI failing CI build job fails labels Jan 10, 2020
@tfr42 tfr42 added the needs rebase PR is not up to date and needs rebase label Aug 15, 2021
@tfr42 tfr42 added the CI failing CI build job fails label Jan 18, 2022
@tfr42 tfr42 added the invalid label Dec 8, 2022
@tfr42 tfr42 removed this from the Backlog milestone Dec 8, 2022
@tfr42 tfr42 added marked for deletion PR with that label will be closed soon and removed CI failing CI build job fails labels Dec 8, 2022
@tfr42
Copy link
Member

tfr42 commented Dec 19, 2022

Based on @diegomigliavacca work a new PR #1437 has been created to support target version 3.5

@tfr42 tfr42 removed feature feature needs rebase PR is not up to date and needs rebase contributions welcome asking for contribution (time and money sponsor) funding welcome financial sponsoring wanted (money) schema change change to deegree configuration files labels Jun 13, 2023
@stephanr
Copy link
Member

The TMC decided to close this PR in favor of #1437

@stephanr stephanr closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate invalid marked for deletion PR with that label will be closed soon stuck stuck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants