XDR IR fix in close_xdr_incident error 500 #37246
Open
+34
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
||||||||||||||||||||||||||||||
|
@maimorag @Shellyber Doc review completed. |
changes from doc review Co-authored-by: ShirleyDenkberg <[email protected]>
Shellyber
reviewed
Nov 17, 2024
| @@ -1041,7 +1041,10 @@ def update_remote_system_command(client, args): | |||
|
|
|||
| if not close_xdr_incident and (update_args.get('status') in XSOAR_RESOLVED_STATUS_TO_XDR.values()): | |||
| status = update_args.pop('status') | |||
| demisto.debug(f"Popped {status=} from update_args, incident status won't be updated in XDR.") | |||
| resolve_comment = update_args.pop('resolve_comment', None) | |||
There was a problem hiding this comment.
Are you sure that the only field causing this issue is the resolve_comment?
added 10 commits
November 17, 2024 16:13
…cident not selected
Packs/CortexXDR/Integrations/CortexXDRIR/CortexXDRIR_description.md
Outdated
Show resolved
Hide resolved
|
@noydavidi Doc reviewed again. |
docs review changes Co-authored-by: ShirleyDenkberg <[email protected]>
Shellyber
reviewed
Nov 18, 2024
| @@ -1041,7 +1041,10 @@ def update_remote_system_command(client, args): | |||
|
|
|||
| if not close_xdr_incident and (update_args.get('status') in XSOAR_RESOLVED_STATUS_TO_XDR.values()): | |||
| status = update_args.pop('status') | |||
| demisto.debug(f"Popped {status=} from update_args, incident status won't be updated in XDR.") | |||
| resolve_comment = update_args.pop('resolve_comment', None) | |||
| if not close_xdr_incident and (update_args.get('status') in XSOAR_RESOLVED_STATUS_TO_XDR.values()): | ||
| status = update_args.pop('status') | ||
| demisto.debug(f"Popped {status=} from update_args, incident status won't be updated in XDR.") | ||
| popped_status = update_args.pop('status') |
There was a problem hiding this comment.
Let's change the terminology back to status, and add maybe a comment for the if statement so it will be clear what it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
Fixed an issue with outgoing mirroring when closing an incident in Cortex XSOAR with close_xdr_incident set to False resulted in a 500 error.
Fixed an issue with outgoing mirroring when closing an incident in Cortex XSOAR with close_xdr_incident set to False and close_alerts_in_xdr set to True resulted in an error.
Must have