Update RSANetWitnessv115.py with fetch alerts api call #37261
Conversation
Update RSANetWitnessv115.py with fetch alerts api call
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/adit-ghildiyal_master
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @amshamah419 will know the proposed changes are ready to be reviewed. |
|
Hi @adit-ghildiyal, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
| }) | ||
|
|
||
| response = self._http_request( | ||
| 'GET', f'rest/api/alert/fetch', data=data |
There was a problem hiding this comment.
| 'GET', f'rest/api/alert/fetch', data=data | |
| 'GET', 'rest/api/alert/fetch', data=data |
There was a problem hiding this comment.
Hi @adit-ghildiyal thanks for your contribution! Do you have some documentation about the API endpoint change?
Also, we should bump the pack version when making changes. You can do this via the demisto-sdk by running demisto-sdk update-release-notes -i Packs/RSANetWitness_v11_1
| @@ -91,10 +91,23 @@ def incident_add_journal_entry_request(self, id_: str | None, author, notes: str | |||
|
|
|||
| def incident_list_alerts_request(self, page_size: str | None, page_number: str | None, id_: str | None) -> dict: | |||
| params = assign_params(pageNumber=page_number, pageSize=page_size) | |||
There was a problem hiding this comment.
Did they change the API endpoint here? I ask because it looks like we are no longer using the page_number and page_size arguments. If the new endpoint supports it, we should try and keep this functionality.
Update RSANetWitnessv115.py with fetch alerts api call
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have