Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): fix process.stdin.pause() #25864

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix(ext/node): fix process.stdin.pause() #25864

merged 1 commit into from
Sep 26, 2024

Conversation

littledivy
Copy link
Member

Fixes #25844

bartlomieju
bartlomieju approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided there's a smoke test

@littledivy
Copy link
Member Author

https://github.com/denoland/npm_smoke_tests/commit/a814b38a1e035d2172c382072ac033504d067c5b

@littledivy littledivy merged commit 121d969 into denoland:main Sep 26, 2024
17 checks passed
@littledivy littledivy deleted the pause-tty-socket branch September 26, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: process doesn't exit with create-vite package
2 participants
@littledivy @bartlomieju