fix(node): implement libuv APIs needed to support npm:sqlite3
#25893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
reviewed
Sep 27, 2024
cli/napi/uv.rs
Outdated
| } | ||
|
|
||
| #[no_mangle] | ||
| unsafe extern "C" fn uv_mutex_lock(lock: *mut uv_mutex_t) { |
There was a problem hiding this comment.
these could be written in terms of std::sync::Mutex and gain safety and platform compat.
There was a problem hiding this comment.
Done, though I went with parking_lot::Mutex instead to avoid having to store the guard with a fake lifetime.
| unsafe { | ||
| *uv_loop = env_ptr.cast(); | ||
| } | ||
| 0 |
There was a problem hiding this comment.
i worry slightly that by allowing node-api modules to progress beyond calling this function, we may see an increase in reports of symbol resolution crashes that were previously just runtime errors.
| - size_of::<uv_async_cb>() | ||
| - size_of::<napi_async_work>() | ||
| }], | ||
| } |
There was a problem hiding this comment.
maybe add smth like this just to be sure.
const _: () = assert!(std::mem::size_of::<uv_async_t>() == UV_ASYNC_SIZE)or maybe a test which compares it to the uv_sys_lite type?
littledivy
reviewed
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24740.
Implements the
uv_mutex_*anduv_async_*APIs.The mutex API is implemented exactly as libuv, a thin wrapper over the OS's native mutex.
The async API is implemented in terms of napi_async_work. As documented in the napi docs, you really shouldn't call
napi_queue_async_workmultiple times (it is documented as undefined behavior). However, our implementation doesn't have any issue with this, so I believe it suits our purpose here.