Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTRA]fix dtrader v2 events for open action and guide action #17507

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vinu-deriv
Copy link
Contributor

Changes:

Fix for tracking events in dtrader v2 for open and guide action

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 14, 2024 11:46am

Copy link
Contributor

github-actions bot commented Nov 14, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17507](https://github.com/deriv-com/deriv-app/pull/17507)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-vinu-deriv-vinu-grwt-1721fix-dtrader-b3d037.binary.sx?qa_server=red.derivws.com&app_id=24061
    - **Original**: https://deriv-app-git-fork-vinu-deriv-vinu-grwt-1721fix-dtrader-b3d037.binary.sx
- **App ID**: `24061`

@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 11835853722

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.001%) to 53.151%

Files with Coverage Reduction New Missed Lines %
packages/trader/src/Analytics/index.ts 1 50.0%
packages/trader/src/AppV2/app.tsx 1 85.71%
Totals Coverage Status
Change from base Build 11820031634: -0.001%
Covered Lines: 32699
Relevant Lines: 57375

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Nov 14, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-vinu-deriv-vinu-grwt-1721fix-dtrader-b3d037.binary.sx/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants