Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT] farabi/bot-2324/blockly-blocks-getting-duplicated-on-add-button-click #17518

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

farabi-deriv
Copy link
Contributor

Changes:

  • Removed createBlock method call from inside addBlockNode

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 18, 2024 3:27pm

Copy link
Contributor

github-actions bot commented Nov 15, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17518](https://github.com/deriv-com/deriv-app/pull/17518)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-2324blockly-b-6d41a4.binary.sx?qa_server=red.derivws.com&app_id=32227
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-2324blockly-b-6d41a4.binary.sx
- **App ID**: `32227`

@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11895183079

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 244 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.7%) to 53.853%

Files with Coverage Reduction New Missed Lines %
packages/appstore/src/constants/wallet-migration-video-translations.ts 1 71.43%
packages/core/src/Utils/Analytics/index.ts 1 0.0%
packages/appstore/src/modules/traders-hub/index.tsx 2 88.51%
packages/wallets/src/features/cfd/components/DynamicLeverageContext/DynamicLeverageContext.tsx 2 0.0%
packages/wallets/webpack.config.js 2 0.0%
packages/trader/src/AppV2/Components/ActiveSymbolsList/active-symbols-list.tsx 4 68.18%
packages/bot-web-ui/src/stores/google-drive-store.ts 50 26.32%
packages/appstore/src/components/cfds-listing/index.tsx 64 32.04%
packages/core/src/Stores/traders-hub-store.js 118 0.0%
Totals Coverage Status
Change from base Build 11850997705: 0.7%
Covered Lines: 32672
Relevant Lines: 56626

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Nov 15, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-2324blockly-b-6d41a4.binary.sx/

sandeep-deriv
sandeep-deriv previously approved these changes Nov 15, 2024
rupato-deriv
rupato-deriv previously approved these changes Nov 15, 2024
Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants