Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-5114 / Replace svg icon in cashier demo overlay #17542

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Replace svg icon in cashier demo overlay with quill icons
  • Match UI with existing implementation
  • Updated unit test

Screenshots:

Bildschirmaufnahme.2024-11-18.um.2.41.13.PM.mov
Bildschirmfoto 2024-11-18 um 2 42 42 PM Bildschirmfoto 2024-11-18 um 2 43 21 PM

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 18, 2024 8:28am

Copy link
Contributor

github-actions bot commented Nov 18, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17542](https://github.com/deriv-com/deriv-app/pull/17542)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-5114-replace-icon-i-adfe0b.binary.sx?qa_server=red.derivws.com&app_id=30371
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-5114-replace-icon-i-adfe0b.binary.sx
- **App ID**: `30371`

Copy link
Contributor

github-actions bot commented Nov 18, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-5114-replace-icon-i-adfe0b.binary.sx/

@coveralls
Copy link

coveralls commented Nov 18, 2024

Pull Request Test Coverage Report for Build 11888183676

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 53.224%

Totals Coverage Status
Change from base Build 11885848490: 0.006%
Covered Lines: 32760
Relevant Lines: 57460

💛 - Coveralls

Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants