Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #455

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Code cleanup #455

merged 5 commits into from
Aug 7, 2024

Conversation

shilgapira
Copy link
Member

Description

  • Don't do go mod vendor anymore
  • Update create access key to move description next to name
  • Add missing test coverage for 100%
  • Add compilation warning for missing methods in management implementations
  • Fix symbol visibility for SSOApplications

Must

  • Tests
  • Documentation (if applicable)

@shilgapira shilgapira self-assigned this Aug 7, 2024
@shilgapira shilgapira enabled auto-merge (squash) August 7, 2024 14:24
@dorsha dorsha requested a review from orius123 August 7, 2024 17:07
@shilgapira shilgapira merged commit 8a6c2c5 into main Aug 7, 2024
5 checks passed
@shilgapira shilgapira deleted the cleanup branch August 7, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orius123 orius123 orius123 approved these changes

@dorsha dorsha Awaiting requested review from dorsha

@aviadl aviadl Awaiting requested review from aviadl

@OfekAvergil OfekAvergil Awaiting requested review from OfekAvergil

Assignees

@shilgapira shilgapira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilgapira @orius123