Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend LogViewer to support scrollable search #10005

Open
wants to merge 9 commits into
base: gt/490-regex-search-task-logs
Choose a base branch
from

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Oct 1, 2024

Ticket

MD-492

Description

Extend run logs to support search by regex and scrollable search

Screen.Recording.2024-10-01.at.12.33.53.PM.mov

Test Plan

Navigate to a run, search for logs with Regex enabled and disabled.
Click on a log to make it scrollable.
Note that the search result is not auto updating, and if the selected log is far away from the current "window", it may take couple scrolls to get there.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@gt2345 gt2345 requested a review from a team as a code owner October 1, 2024 17:38
@cla-bot cla-bot bot added the cla-signed label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 14.34540% with 615 lines in your changes missing coverage. Please review.

Project coverage is 54.40%. Comparing base (df11fb3) to head (d72330a).

Files with missing lines Patch % Lines
webui/react/src/pages/TrialDetails/LogViewer.tsx 17.45% 435 Missing ⚠️
.../react/src/pages/TrialDetails/TrialDetailsLogs.tsx 5.29% 179 Missing ⚠️
webui/react/src/services/decoder.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           gt/490-regex-search-task-logs   #10005      +/-   ##
=================================================================
- Coverage                          54.58%   54.40%   -0.19%     
=================================================================
  Files                               1258     1259       +1     
  Lines                             157161   157861     +700     
  Branches                            3619     3619              
=================================================================
+ Hits                               85789    85884      +95     
- Misses                             71239    71844     +605     
  Partials                             133      133              
Flag Coverage Δ
backend 45.33% <ø> (-0.02%) ⬇️
harness 72.74% <ø> (ø)
web 53.97% <14.34%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/types.ts 99.70% <100.00%> (+<0.01%) ⬆️
webui/react/src/services/decoder.ts 21.32% <0.00%> (-0.03%) ⬇️
.../react/src/pages/TrialDetails/TrialDetailsLogs.tsx 10.81% <5.29%> (-5.05%) ⬇️
webui/react/src/pages/TrialDetails/LogViewer.tsx 17.45% <17.45%> (ø)

... and 3 files with indirect coverage changes

@gt2345 gt2345 force-pushed the gt/490-regex-search-task-logs branch from 91c869a to df11fb3 Compare October 1, 2024 17:39
@gt2345 gt2345 requested a review from a team as a code owner October 1, 2024 17:39
@gt2345 gt2345 requested review from ShreyaLnuHpe and removed request for a team October 1, 2024 17:39
@gt2345 gt2345 requested review from EmilyBonar, jgongd and MikhailKardash and removed request for ShreyaLnuHpe October 1, 2024 17:41
Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants