-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extend LogViewer to support scrollable search #10005
Open
gt2345
wants to merge
9
commits into
gt/490-regex-search-task-logs
Choose a base branch
from
gt/492-logviewer-search
base: gt/490-regex-search-task-logs
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+796
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gt/490-regex-search-task-logs #10005 +/- ##
=================================================================
- Coverage 54.58% 54.40% -0.19%
=================================================================
Files 1258 1259 +1
Lines 157161 157861 +700
Branches 3619 3619
=================================================================
+ Hits 85789 85884 +95
- Misses 71239 71844 +605
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gt2345
force-pushed
the
gt/490-regex-search-task-logs
branch
from
October 1, 2024 17:39
91c869a
to
df11fb3
Compare
gt2345
force-pushed
the
gt/492-logviewer-search
branch
from
October 1, 2024 17:40
8199862
to
30cec4b
Compare
gt2345
requested review from
EmilyBonar,
jgongd and
MikhailKardash
and removed request for
ShreyaLnuHpe
October 1, 2024 17:41
MikhailKardash
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
MD-492
Description
Extend run logs to support search by regex and scrollable search
Screen.Recording.2024-10-01.at.12.33.53.PM.mov
Test Plan
Navigate to a run, search for logs with Regex enabled and disabled.
Click on a log to make it scrollable.
Note that the search result is not auto updating, and if the selected log is far away from the current "window", it may take couple scrolls to get there.
Checklist
docs/release-notes/
See Release Note for details.