Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added keyword for role create and delete #97

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Added keyword for role create and delete #97

wants to merge 50 commits into from

Conversation

rohini-nubolab
Copy link

Added keyword for role create and delete

Fixes #96

rohini-nubolab and others added 30 commits October 1, 2021 13:38
@rohini-nubolab
Added keyword for create and delete role
419d410
@rohini-nubolab
Added index.html
8a336d3
@rohini-nubolab
Added role binding
e6af6c2
@rohini-nubolab
Update role_kw.robot
60f27dd
@rohini-nubolab
Update .coveragerc
e7cb010
@rohini-nubolab
Update role_kw.robot
fde6cc0
@rohini-nubolab
Merge branch 'master' into master
b50a0d9
@rohini-nubolab
Added keywords
5f1a50a
@rohini-nubolab
Update KubeLibrary.py
289031e
@rohini-nubolab
Update KubeLibrary.py
1103cc0
@rohini-nubolab
Update KubeLibrary.py
bc10f48
@rohini-nubolab
Update KubeLibrary.py
e95df5a
@rohini-nubolab
Update configmap.robot
5cc49d7
@rohini-nubolab
Update cronjob.robot
4f0e2fc
@rohini-nubolab
Update daemonsets.robot
8398a0d
@rohini-nubolab
Update configmap_kw.robot
066dd58
@rohini-nubolab
Update cronjob_kw.robot
dee5c0a
@rohini-nubolab
Update daemonsets_kw.robot
6de8dc3
@rohini-nubolab
Update deployment_kw.robot
09f9a53
@rohini-nubolab
Update ingress.robot
0e95f7d
@rohini-nubolab
Update ingress_kw.robot
659f022
@rohini-nubolab
Update ingress_kw.robot
7066d87
@rohini-nubolab
Update pod.robot
50c75f9
@rohini-nubolab
Update pod_kw.robot
3738af8
@rohini-nubolab
Update pvc.robot
af4511e
@rohini-nubolab
Update pvc_kw.robot
6e22d3b
@rohini-nubolab
Update replicaset.robot
00fc6e3
@rohini-nubolab
Update replicaset_kw.robot
cbd3868
@rohini-nubolab
Update role.robot
ee9b1bd
@rohini-nubolab
Update role.robot
1d18007
m-wcislo
m-wcislo requested changes Oct 25, 2021
View reviewed changes
.coveragerc Outdated
@@ -3,4 +3,4 @@ command_line = -m unittest discover
source =
src/
[report]
fail_under = 84
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't decrease coverage

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/KubeLibrary/KubeLibrary.py Outdated
@@ -1013,3 +1013,35 @@ def filter_endpoints_names(self, endpoints):
List of endpoint objects
"""
return [endpoints.metadata.name for endpoints in endpoints.items]

def get_role_details_in_namespace(self, name, namespace):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name the functions same as Kubernetes python library function - in this case read_namespaced_role (see #75)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still you need to do it for create_role_in_namespace and delete_role_in_namespace

@m-wcislo
Copy link
Collaborator

Complete checklist

At least one example testcase added in testcases/
Library Documentation regenerated according to Generate docs
All new testcases tagged as prerelease along other tags to exclude it from execution until released on PyPI
Coverage threshold increased in .coveragerc if new coverage is higher than actual, see the lint-and-coverage step in CI

@rohini-nubolab
Copy link
Author

Complete checklist

At least one example testcase added in testcases/
Library Documentation regenerated according to Generate docs
All new testcases tagged as prerelease along other tags to exclude it from execution until released on PyPI
Coverage threshold increased in .coveragerc if new coverage is higher than actual, see the lint-and-coverage step in CI

done

m-wcislo
m-wcislo requested changes Nov 17, 2021
View reviewed changes
test/test_KubeLibrary.py
mock_lnp.side_effect = mock_create_role_in_namespace
kl = KubeLibrary(kube_config='test/resources/k3d')
name = 'pod-reader'
role_manifest = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this test has no value, we are not testing anything as everything is mocked. One thing that might be useful is testing handling situation when role is already created with some meaningful output.

test/test_KubeLibrary.py
@@ -678,3 +694,53 @@ def test_get_cron_job_details_in_namespace(self, mock_lnp):
kl = KubeLibrary(kube_config='test/resources/k3d')
cron_job_details = kl.get_cron_job_details_in_namespace('hello', 'default')
self.assertEqual('mytestlabel', cron_job_details.items.metadata.labels.TestLabel)

@mock.patch('kubernetes.client.RbacAuthorizationV1Api.delete_namespaced_role')
def test_delete_role_in_namespace(self, mock_lnp):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could test handling situation when there is no role to remove. Other than that the mocked response is wrong because as I understand it will return V1 status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-wcislo m-wcislo m-wcislo requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add keyword for create and delete role ,role binding
2 participants
@rohini-nubolab @m-wcislo