Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor nonce specification in HttpAgent #944

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krpeacock
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock
Copy link
Contributor Author

@frederikrothenberger a WIP, but related to #941 changes, allowing nonce to be passed directly to call and query on the agent

I'll need to add support for taking advantage of this when using an Actor by adding nonce to withOptions before it's ready

Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/agent 86.08 KB (+0.07% 🔺)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 4.97 KB (0%)
@dfinity/auth-client 60.36 KB (0%)
@dfinity/assets 81.19 KB (0%)
@dfinity/identity 57.56 KB (0%)
@dfinity/identity-secp256k1 131.36 KB (+0.04% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant