feat: EXC-1735: Move scheduling into the inner round #1757
+149
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berestovskyy
force-pushed
the
andriy/exc-1735-shedule-inner-round
branch
2 times, most recently
from
0a2a8f3
to
f0ea8a7
Compare
By moving the scheduling strategy into the inner round, we can adjust canister priorities within each round. This allows for greater flexibility and responsiveness to change canister priorities.
berestovskyy
force-pushed
the
andriy/exc-1735-shedule-inner-round
branch
from
f0ea8a7
to
d4cd725
Compare
berestovskyy
changed the title
dsarlis
reviewed
Oct 1, 2024
| // Scheduling. | ||
| // TODO(EXC-1617): The scheduling will be optimized in the follow up PRs. | ||
| let (mut active_canisters_partitioned_by_cores, inactive_canisters) = { | ||
| let _timer = self.metrics.round_scheduling_duration.start_timer(); |
There was a problem hiding this comment.
Potentially the name of the metric needs adjustment, i.e. inner_round_* might be more appropriate. Given that changing names can break dashboards, we can defer it to another PR.
Comment on lines
+370
to
+372
| // Decrease accumulated priorities of the top `scheduler_cores` canisters. | ||
| // This is required to respect scheduler invariant after the round is finished. | ||
| canister_state.scheduler_state.accumulated_priority -= |
There was a problem hiding this comment.
I'm not sure I follow how this is now equivalent to the code before. Can you maybe explain this part a bit?
| assert_eq!(canister.system_state.canister_metrics.executed, 2); | ||
| assert!(!canister.has_paused_execution()); | ||
|
|
||
| // The accumulated priority should not increase after the long execution is finished. |
There was a problem hiding this comment.
Is this a change in behaviour compared to current state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the scheduling strategy into the inner round, we can adjust canister priorities within each round. This allows for greater flexibility and responsiveness to change canister priorities.