Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move the xnet endpoint under rs/http_endpoints and share ownership with the NET team #1762

Merged
merged 5 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ go_deps.bzl @dfinity/idx
/rs/fuzzers/ @dfinity/product-security
/rs/http_endpoints/ @dfinity/networking
/rs/http_endpoints/fuzz/ @dfinity/product-security
/rs/http_endpoints/xnet/ @dfinity/networking @dfinity/ic-message-routing-owners
/rs/http_utils/ @dfinity/consensus
/rs/https_outcalls/ @dfinity/networking
/rs/https_outcalls/consensus/ @dfinity/consensus
Expand Down
82 changes: 41 additions & 41 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,9 @@ members = [
"rs/execution_environment",
"rs/execution_environment/benches/lib",
"rs/execution_environment/tools",
"rs/http_endpoints/public",
"rs/http_endpoints/metrics",
"rs/http_endpoints/public",
"rs/http_endpoints/xnet",
"rs/http_utils",
"rs/ic_os/dev_test_tools/deterministic_ips",
"rs/ic_os/build_tools/dflate",
Expand Down Expand Up @@ -246,6 +247,7 @@ members = [
"rs/registry/proto_data_provider",
"rs/registry/provisional_whitelist",
"rs/registry/regedit",
"rs/registry/node_provider_rewards",
"rs/registry/nns_data_provider",
"rs/registry/nns_data_provider_wrappers",
"rs/registry/routing_table",
Expand Down Expand Up @@ -394,11 +396,9 @@ members = [
"rs/validator/ingress_message",
"rs/validator/ingress_message/test_canister",
"rs/workload_generator",
"rs/xnet/endpoint",
"rs/xnet/hyper",
"rs/xnet/payload_builder",
"rs/xnet/uri",
"rs/registry/node_provider_rewards",
]

resolver = "2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ DEV_DEPENDENCIES = [
]

rust_library(
name = "endpoint",
name = "xnet",
srcs = glob(["src/**"]),
crate_name = "ic_xnet_endpoint",
crate_name = "ic_http_endpoints_xnet",
version = "0.9.0",
deps = DEPENDENCIES,
)

rust_test(
name = "endpoint_test",
crate = ":endpoint",
name = "test",
crate = ":xnet",
deps = DEV_DEPENDENCIES,
)
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[package]
name = "ic-xnet-endpoint"
name = "ic-http-endpoints-xnet"
version.workspace = true
authors.workspace = true
edition.workspace = true
Expand Down
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion rs/replica/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ DEPENDENCIES = [
"//rs/execution_environment",
"//rs/http_endpoints/metrics",
"//rs/http_endpoints/public",
"//rs/http_endpoints/xnet",
"//rs/https_outcalls/client",
"//rs/interfaces",
"//rs/interfaces/certified_stream_store",
Expand All @@ -35,7 +36,6 @@ DEPENDENCIES = [
"//rs/state_manager",
"//rs/sys",
"//rs/types/types",
"//rs/xnet/endpoint",
"//rs/xnet/payload_builder",
"@crate_index//:clap_3_2_25",
"@crate_index//:hex",
Expand Down
2 changes: 1 addition & 1 deletion rs/replica/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ ic-cycles-account-manager = { path = "../cycles_account_manager" }
ic-execution-environment = { path = "../execution_environment" }
ic-http-endpoints-metrics = { path = "../http_endpoints/metrics" }
ic-http-endpoints-public = { path = "../http_endpoints/public" }
ic-http-endpoints-xnet = { path = "../http_endpoints/xnet" }
ic-https-outcalls-adapter-client = { path = "../https_outcalls/client" }
ic-interfaces = { path = "../interfaces" }
ic-interfaces-certified-stream-store = { path = "../interfaces/certified_stream_store" }
Expand All @@ -41,7 +42,6 @@ ic-state-manager = { path = "../state_manager" }
ic-sys = { path = "../sys" }
ic-tracing = { path = "../monitoring/tracing" }
ic-types = { path = "../types/types" }
ic-xnet-endpoint = { path = "../xnet/endpoint" }
ic-xnet-payload-builder = { path = "../xnet/payload_builder" }
libc = { workspace = true }
nix = { workspace = true }
Expand Down
2 changes: 1 addition & 1 deletion rs/replica/src/setup_ic_stack.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ use ic_consensus::certification::VerifierImpl;
use ic_crypto::CryptoComponent;
use ic_cycles_account_manager::CyclesAccountManager;
use ic_execution_environment::ExecutionServices;
use ic_http_endpoints_xnet::XNetEndpoint;
use ic_https_outcalls_adapter_client::setup_canister_http_client;
use ic_interfaces::{
execution_environment::QueryExecutionService, p2p::artifact_manager::JoinGuard,
Expand All @@ -33,7 +34,6 @@ use ic_types::{
messages::SignedIngress,
Height, NodeId, PrincipalId, SubnetId,
};
use ic_xnet_endpoint::XNetEndpoint;
use ic_xnet_payload_builder::XNetPayloadBuilderImpl;
use std::{
str::FromStr,
Expand Down
Loading