Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add keys() and vals() for AssocList #646

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add keys() and vals() for AssocList #646

wants to merge 3 commits into from

Conversation

dpanchenko
Copy link

No description provided.

@sa-github-api
Copy link

Dear @dpanchenko,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

timohanke
timohanke reviewed Jul 22, 2024
View reviewed changes
Copy link

@timohanke timohanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use List.toIter instead of the entries function defined here. It is the same code, but just because List.toIter already exists we don't need to provide it a second time.

@dpanchenko dpanchenko marked this pull request as ready for review July 22, 2024 23:41
timohanke
timohanke approved these changes Jul 23, 2024
View reviewed changes
Copy link

@timohanke timohanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timohanke
Copy link

Resolves #581

@timohanke
Copy link

I don't know about the size requirement for keys() and vals(). Does anyone know if it is really O(1)?

@timohanke timohanke mentioned this pull request Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timohanke timohanke timohanke approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
external-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpanchenko @sa-github-api @timohanke