Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR: DotPrim elim #4614

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

IR: DotPrim elim #4614

wants to merge 30 commits into from

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Jul 12, 2024 •
edited
Loading

DotPrim on a literal object can be reduced.

Records/objects are expensive to create (heap- and cycles-wise), so doing a compile-time garbage-collection seems reasonable.

TODO:

  • use FileCheck on //MOC-FLAG -dl output?
  • other types of definition junk? (must not trap to qualify!)
    • DotPrim from VarE?
    • NewObjE?

ggreif added 11 commits July 12, 2024 12:21
@ggreif
don't create unnecessary variable renaming for the sake of NewObjE
f839501 
`NewObjE` wants variable names for field values. When the expression
is _already a variable_ then just reuse its name!
@ggreif
relax IR typechecker to accept
aa1bb2e 
a `var` as source for an immutable field
@ggreif
improve the IR interpreter to allow immutable field initialisation by…
4049c14 
… reading mutable boxes

This is also how the backend does it.
@ggreif
blockE does the right thing here
75143f1
@ggreif
test
6dbefb8
@ggreif
Merge branch 'master' into gabor/NewObjE
06f070c
@ggreif
WIP: recover from stash
de2116f 
make `dotE` more intelligent
@ggreif
progress: cope with many fields in NewObjE
789eb2e
@ggreif
drill into the result of BlockE
20fd51b
@ggreif
prune all LitE junk from the definitions
bb6c2c3 
unless it is a precious one, needed in the result
@ggreif
accept
cbf141a
@ggreif ggreif changed the base branch from master to gabor/NewObjE July 12, 2024 23:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 13, 2024 •
edited
Loading

Comparing from a001388 to d5850b9:
In terms of gas, no changes are observed in 5 tests.
In terms of size, no changes are observed in 5 tests.

@ggreif ggreif changed the title Gabor/dot prim elim IR: DotPrim elim Jul 16, 2024
Base automatically changed from gabor/NewObjE to master July 16, 2024 18:07
@ggreif ggreif self-assigned this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ggreif ggreif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ggreif