Update spec and use promise.all instead of promise.allSettled

dfinity · Oct 1, 2024 · fb0d26c · fb0d26c
1 parent d7eee5d
commit fb0d26c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/frontend/src/lib/services/neurons.services.ts b/frontend/src/lib/services/neurons.services.ts
@@ -1021,7 +1021,7 @@ export const changeNeuronVisibility = async ({
   neurons: NeuronInfo[];
   makePublic: boolean;
 }): Promise<{ success: boolean }> => {
-  const results = await Promise.allSettled(
+  const results = await Promise.all(
     neurons.map(async (neuron) => {
       try {
         const identity: Identity = await getIdentityOfControllerByNeuronId(
@@ -1046,9 +1046,7 @@ export const changeNeuronVisibility = async ({
     })
   );
 
-  const failedCount = results.filter(
-    (result) => result.status === "rejected" || result.value === false
-  ).length;
+  const failedCount = results.filter((result) => result === false).length;
 
   if (failedCount === 0) {
     return { success: true };

diff --git a/frontend/src/tests/lib/services/neurons.services.spec.ts b/frontend/src/tests/lib/services/neurons.services.spec.ts
@@ -1923,7 +1923,7 @@ describe("neurons-services", () => {
       expect(spyChangeNeuronVisibility).toBeCalledTimes(2);
       expect(spyGetNeuron).toBeCalledTimes(1);
       expectToastError(
-        '1 of 2 neurons failed to update. Please try again later. You can always change neuron visibility settings under "Advanced Details & Settings".'
+        '1 out of 2 neurons have failed to update their visibility, please try again later. You can always change neuron visibility under "Advanced Details & Settings".'
       );
     });
 
@@ -1942,7 +1942,7 @@ describe("neurons-services", () => {
       expect(spyChangeNeuronVisibility).toBeCalledTimes(1);
       expect(spyGetNeuron).not.toBeCalled();
       expectToastError(
-        'All neurons have failed to update their visibility. Please try again later. You can always change neuron visibility settings under "Advanced Details & Settings".'
+        'Your neurons have failed to update their visibility, please try again later. You can always change neuron visibility under "Advanced Details & Settings".'
       );
     });